@matheusbsbs / matheus-bagliano / commits / 69dd97a430
Fork 0

Revert "Allow wish interpreter to be defined with TCLTK_PATH"

This reverts commit e2a1bc67d321a0c03737179f331c39a52e7049d7. Junio rightly pointed out this patch doesn't handle the `make install` target very well: Junio C Hamano <junkio@cox.net> writes: > You should never generate new files in the source tree from > 'install' target. Otherwise, the usual pattern of "make" as > yourself and then "make install" as root would not work from a > "root-to-nobody-squashing" NFS mounted source tree to local > filesystem. You should know better than accepting such a patch.

Shawn O. Pearce committed Apr 17, 2007 at 13:15 UTC 69dd97a430d3deebbcade1d38c53110342440890
1 file changed -3
Makefile
-3
@@ -28,8 +28,6 @@ ifndef V
28 QUIET_BUILT_IN = @echo ' ' BUILTIN $@;
29 endif
30
31 -TCLTK_PATH ?= wish
32 -
31 ifeq ($(findstring $(MAKEFLAGS),s),s)
32 QUIET_GEN =
33 QUIET_BUILT_IN =
@@ -57,7 +55,6 @@ all:: $(ALL_PROGRAMS)
55
56 install: all
57 $(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
60 - sed -i .bak -e'1,3s|^exec .* "$$0"|exec '"$(TCLTK_PATH)"' "$$0"|' git-gui && rm git-gui.bak
58 $(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'
59 $(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)
60