vcs-svn: suppress signed/unsigned comparison warnings
These are already safe because both sides of the comparison are nonnegative. This would normally not be important because Git is not -Wsign-compare clean anyway, but we like to keep the vcs-svn/ lib to a higher standard for convenience using it in other projects. Signed-off-by: David Barr <davidbarr@google.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
David Barr committed
Jun 1, 2012 at 00:41 UTC
6a0b4438afc22551533dccc221bdf802ee4ed5ee
1 file changed
+2
-2
vcs-svn/fast_export.c
+2
-2
@@ -254,7 +254,7 @@ static int parse_ls_response(const char *response, uint32_t *mode,
254
}
255
256
/* Mode. */
257
- if (response_end - response < strlen("100644") ||
257
+ if (response_end - response < (signed) strlen("100644") ||
258
response[strlen("100644")] != ' ')
259
die("invalid ls response: missing mode: %s", response);
260
*mode = 0;
@@ -267,7 +267,7 @@ static int parse_ls_response(const char *response, uint32_t *mode,
267
}
268
269
/* ' blob ' or ' tree ' */
270
- if (response_end - response < strlen(" blob ") ||
270
+ if (response_end - response < (signed) strlen(" blob ") ||
271
(response[1] != 'b' && response[1] != 't'))
272
die("unexpected ls response: not a tree or blob: %s", response);
273
response += strlen(" blob ");