SubmittingPatches: Clarify the Signed-off-by rules

The wording of the Signed-off-by rules could be read as stating that S-O-B should only be added when the submitter considered the patch ready for inclusion in git.git. We also want Signed-off-by to be used for e.g. RFC patches, in case someone wants to dig an old patch out of the archive and improve it. Change the wording to recommend a Signed-off-by for all submitted patches. The problem with the wording came up in the "[PATCH/RFC] Hacky version of a glob() driven config include" thread[1]. Bert Wesarg suggested[2] that it be removed to avoid confusion, which this change implements. 1. <1273180440-8641-1-git-send-email-avarab@gmail.com> 2. <AANLkTimziTKL13VKIOcaS1TX1F_xvTVjH8Q398Yx36Us@mail.gmail.com> Suggested-by: Bert Wesarg <bert.wesarg@googlemail.com> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Jul 28, 2010 at 14:12 UTC 6a58696f5b446cef4874c45b1c953403707325b8

1 file changed +3 -5

Documentation/SubmittingPatches

+3 -5

@@ -13,11 +13,9 @@ Checklist (and a short version for the impatient):

13 not "changed" or "changes".

14 - includes motivation for the change, and contrasts

15 its implementation with previous behaviour

16 - - if you want your work included in git.git, add a

17 - "Signed-off-by: Your Name <you@example.com>" line to the

18 - commit message (or just use the option "-s" when

19 - committing) to confirm that you agree to the Developer's

20 - Certificate of Origin

16 + - add a "Signed-off-by: Your Name <you@example.com>" line to the

17 + commit message (or just use the option "-s" when committing)

18 + to confirm that you agree to the Developer's Certificate of Origin

19 - make sure that you have tests for the bug you are fixing

20 - make sure that the test suite passes after your commit