submodule: drop unused sm_name parameter from append_fetch_remotes()
Commit c21fb4676f (submodule--helper: fix incorrect newlines in an error message, 2021-10-23) accidentally added a new, unused parameter while changing the name and signature of show_fetch_remotes() to append_fetch_remotes(). We can drop this to keep things simpler (and satisfy -Wunused-parameter). The error is likely because c21fb4676f is fixing a problem from 8c8195e9c3 (submodule--helper: introduce add-clone subcommand, 2021-07-10). An earlier iteration of that second commit introduced the same unused parameter (though it was dropped before it finally made it to 'next'), and the fix on top accidentally carried forward the extra parameter. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Oct 26, 2021 at 01:25 UTC
6b615dbeced33c67d42d3a5062207b8495ecf2a8
1 file changed
+2
-3
builtin/submodule--helper.c
+2
-3
@@ -2776,7 +2776,7 @@ struct add_data {
2776
};
2777
#define ADD_DATA_INIT { .depth = -1 }
2778
2779
-static void append_fetch_remotes(struct strbuf *msg, const char *sm_name, const char *git_dir_path)
2779
+static void append_fetch_remotes(struct strbuf *msg, const char *git_dir_path)
2780
{
2781
struct child_process cp_remote = CHILD_PROCESS_INIT;
2782
struct strbuf sb_remote_out = STRBUF_INIT;
@@ -2831,8 +2831,7 @@ static int add_submodule(const struct add_data *add_data)
2831
"locally with remote(s):\n"),
2832
add_data->sm_name);
2833
2834
- append_fetch_remotes(&msg, add_data->sm_name,
2835
- submod_gitdir_path);
2834
+ append_fetch_remotes(&msg, submod_gitdir_path);
2835
free(submod_gitdir_path);
2836
2837
strbuf_addf(&msg, _("If you want to reuse this local git "