@matheusbsbs / matheus-bagliano / commits / 6c6ddf92d5

treewide: be explicit about dependence on advice.h

Dozens of files made use of advice functions, without explicitly including advice.h. This made it more difficult to find which files could remove a dependence on cache.h. Make C files explicitly include advice.h if they are using it. Signed-off-by: Elijah Newren <newren@gmail.com> Acked-by: Calvin Wan <calvinwan@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Elijah Newren committed Apr 11, 2023 at 03:00 UTC 6c6ddf92d511c423b8b54fb1b01d563b6f4c58f7
25 files changed +24 -1
add-patch.c
+1
@@ -1,5 +1,6 @@
1 #include "cache.h"
2 #include "add-interactive.h"
3 +#include "advice.h"
4 #include "alloc.h"
5 #include "environment.h"
6 #include "gettext.h"
branch.c
+1
@@ -1,5 +1,6 @@
1 #include "git-compat-util.h"
2 #include "cache.h"
3 +#include "advice.h"
4 #include "config.h"
5 #include "branch.h"
6 #include "environment.h"
builtin/add.c
+1
@@ -5,6 +5,7 @@
5 */
6 #define USE_THE_INDEX_VARIABLE
7 #include "cache.h"
8 +#include "advice.h"
9 #include "config.h"
10 #include "builtin.h"
11 #include "lockfile.h"
builtin/am.c
+1
@@ -6,6 +6,7 @@
6 #define USE_THE_INDEX_VARIABLE
7 #include "cache.h"
8 #include "abspath.h"
9 +#include "advice.h"
10 #include "config.h"
11 #include "builtin.h"
12 #include "environment.h"
builtin/clone.c
+1
@@ -11,6 +11,7 @@
11 #define USE_THE_INDEX_VARIABLE
12 #include "builtin.h"
13 #include "abspath.h"
14 +#include "advice.h"
15 #include "config.h"
16 #include "environment.h"
17 #include "gettext.h"
builtin/commit.c
+1
@@ -7,6 +7,7 @@
7
8 #define USE_THE_INDEX_VARIABLE
9 #include "cache.h"
10 +#include "advice.h"
11 #include "config.h"
12 #include "lockfile.h"
13 #include "cache-tree.h"
builtin/fetch.c
+1
@@ -2,6 +2,7 @@
2 * "git fetch"
3 */
4 #include "cache.h"
5 +#include "advice.h"
6 #include "config.h"
7 #include "gettext.h"
8 #include "environment.h"
builtin/merge-recursive.c
+1
@@ -1,5 +1,6 @@
1 #include "cache.h"
2 #include "builtin.h"
3 +#include "advice.h"
4 #include "commit.h"
5 #include "gettext.h"
6 #include "tag.h"
builtin/merge.c
+1
@@ -9,6 +9,7 @@
9 #define USE_THE_INDEX_VARIABLE
10 #include "cache.h"
11 #include "abspath.h"
12 +#include "advice.h"
13 #include "alloc.h"
14 #include "config.h"
15 #include "environment.h"
builtin/mv.c
+1
@@ -6,6 +6,7 @@
6 #define USE_THE_INDEX_VARIABLE
7 #include "builtin.h"
8 #include "abspath.h"
9 +#include "advice.h"
10 #include "alloc.h"
11 #include "config.h"
12 #include "environment.h"
builtin/pull.c
+1
@@ -7,6 +7,7 @@
7 */
8 #define USE_THE_INDEX_VARIABLE
9 #include "cache.h"
10 +#include "advice.h"
11 #include "config.h"
12 #include "builtin.h"
13 #include "gettext.h"
builtin/push.c
+1
@@ -2,6 +2,7 @@
2 * "git push"
3 */
4 #include "cache.h"
5 +#include "advice.h"
6 #include "branch.h"
7 #include "config.h"
8 #include "environment.h"
builtin/reset.c
+1
@@ -9,6 +9,7 @@
9 */
10 #define USE_THE_INDEX_VARIABLE
11 #include "builtin.h"
12 +#include "advice.h"
13 #include "config.h"
14 #include "environment.h"
15 #include "gettext.h"
builtin/tag.c
+1
@@ -7,6 +7,7 @@
7 */
8
9 #include "cache.h"
10 +#include "advice.h"
11 #include "config.h"
12 #include "builtin.h"
13 #include "environment.h"
cache.h
-1
@@ -5,7 +5,6 @@
5 #include "strbuf.h"
6 #include "hashmap.h"
7 #include "list.h"
8 -#include "advice.h"
8 #include "gettext.h"
9 #include "convert.h"
10 #include "string-list.h"
config.c
+1
@@ -7,6 +7,7 @@
7 */
8 #include "cache.h"
9 #include "abspath.h"
10 +#include "advice.h"
11 #include "alloc.h"
12 #include "date.h"
13 #include "branch.h"
convert.c
+1
@@ -1,4 +1,5 @@
1 #include "cache.h"
2 +#include "advice.h"
3 #include "config.h"
4 #include "gettext.h"
5 #include "hex.h"
editor.c
+1
@@ -1,5 +1,6 @@
1 #include "cache.h"
2 #include "abspath.h"
3 +#include "advice.h"
4 #include "config.h"
5 #include "environment.h"
6 #include "gettext.h"
notes-merge.c
+1
@@ -1,4 +1,5 @@
1 #include "cache.h"
2 +#include "advice.h"
3 #include "commit.h"
4 #include "gettext.h"
5 #include "refs.h"
object-name.c
+1
@@ -1,4 +1,5 @@
1 #include "cache.h"
2 +#include "advice.h"
3 #include "config.h"
4 #include "environment.h"
5 #include "gettext.h"
refs.c
+1
@@ -3,6 +3,7 @@
3 */
4
5 #include "cache.h"
6 +#include "advice.h"
7 #include "alloc.h"
8 #include "config.h"
9 #include "environment.h"
sequencer.c
+1
@@ -1,5 +1,6 @@
1 #include "cache.h"
2 #include "abspath.h"
3 +#include "advice.h"
4 #include "alloc.h"
5 #include "config.h"
6 #include "environment.h"
transport.c
+1
@@ -1,4 +1,5 @@
1 #include "cache.h"
2 +#include "advice.h"
3 #include "alloc.h"
4 #include "config.h"
5 #include "environment.h"
unpack-trees.c
+1
@@ -1,4 +1,5 @@
1 #include "cache.h"
2 +#include "advice.h"
3 #include "strvec.h"
4 #include "repository.h"
5 #include "config.h"
wt-status.c
+1
@@ -1,4 +1,5 @@
1 #include "cache.h"
2 +#include "advice.h"
3 #include "wt-status.h"
4 #include "object.h"
5 #include "dir.h"