upload-pack: keep poll(2)'s timeout to -1
Keep poll's timeout at -1 when uploadpack.keepalive = 0, instead of setting it to -1000, since some pedantic old systems (eg HP-UX) and the gnulib compat/poll will treat only -1 as the valid value for an infinite timeout. Signed-off-by: Edward Thomson <ethomson@microsoft.com> Acked-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Edward Thomson committed
Aug 22, 2014 at 15:19 UTC
6c71f8b0d3d39beffe050f92f33a25dc30dffca3
1 file changed
+3
-1
upload-pack.c
+3
-1
@@ -158,7 +158,9 @@ static void create_pack_file(void)
158
if (!pollsize)
159
break;
160
161
- ret = poll(pfd, pollsize, 1000 * keepalive);
161
+ ret = poll(pfd, pollsize,
162
+ keepalive < 0 ? -1 : 1000 * keepalive);
163
+
164
if (ret < 0) {
165
if (errno != EINTR) {
166
error("poll failed, resuming: %s",