send-email: don't call methods on undefined values
If SSL verification is enabled in git send-email, we could attempt to call a method on an undefined value if the verification failed, since $smtp would end up being undef. Look up the error string in a way that will produce a helpful error message and not cause further errors. Signed-off-by: Brian M. Carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brian M. Carlson committed
Sep 8, 2013 at 20:54 UTC
6cb0c883052118c35e424af7a311c66be9b366e1
1 file changed
+1
-1
git-send-email.perl
+1
-1
@@ -1234,7 +1234,7 @@ X-Mailer: git-send-email $gitversion
1234
if ($smtp->code == 220) {
1235
$smtp = Net::SMTP::SSL->start_SSL($smtp,
1236
ssl_verify_params())
1237
- or die "STARTTLS failed! ".$smtp->message;
1237
+ or die "STARTTLS failed! ".IO::Socket::SSL::errstr();
1238
$smtp_encryption = '';
1239
# Send EHLO again to receive fresh
1240
# supported commands