userdiff: remove support for "broken" tests

There have been no "broken" tests since 75c3b6b2e8 (userdiff: improve Fortran xfuncname regex, 2020-08-12). Let's remove the test support for them. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Apr 8, 2021 at 17:04 UTC 6cb77966ec8e335fc21ac555a851b81598971ebf
2 files changed +1 -10
t/t4018-diff-funcname.sh
+1 -7
@@ -94,13 +94,7 @@ test_expect_success 'setup hunk header tests' '
94 # check each individual file
95 for i in $(git ls-files)
96 do
97 - if grep broken "$i" >/dev/null 2>&1
98 - then
99 - result=failure
100 - else
101 - result=success
102 - fi
103 - test_expect_$result "hunk header: $i" "
97 + test_expect_success "hunk header: $i" "
98 git diff -U1 $i >actual &&
99 grep '@@ .* @@.*RIGHT' actual
100 "
t/t4018/README
-3
@@ -7,9 +7,6 @@ at least two lines from the line that must appear in the hunk header.
7 The text that must appear in the hunk header must contain the word
8 "right", but in all upper-case, like in the title above.
9
10 -To mark a test case that highlights a malfunction, insert the word
11 -BROKEN in all lower-case somewhere in the file.
12 -
10 This text is a bit twisted and out of order, but it is itself a
11 test case for the default hunk header pattern. Know what you are doing
12 if you change it.