fetch: do not redundantly calculate tag refmap
builtin/fetch.c redundantly calculates refmaps for tags twice. Remove the first calculation. This is only a code simplification and slight performance improvement - the result is unchanged, as the redundant refmaps are subsequently removed by the invocation to "ref_remove_duplicates" anyway. This was introduced in commit c5a84e9 ("fetch --tags: fetch tags *in addition to* other stuff", 2013-10-29) when modifying the effect of the --tags parameter to "git fetch". The refmap-for-tag calculation was copied instead of moved. Signed-off-by: Jonathan Tan <jonathantanmy@google.com> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jonathan Tan committed
Nov 10, 2016 at 16:13 UTC
6cc823c5c15911b27a410cfd47abc81cc10c0003
1 file changed
-3
builtin/fetch.c
-3
@@ -347,9 +347,6 @@ static struct ref *get_ref_map(struct transport *transport,
347
348
for (i = 0; i < fetch_refspec_nr; i++)
349
get_fetch_map(ref_map, &fetch_refspec[i], &oref_tail, 1);
350
-
351
- if (tags == TAGS_SET)
352
- get_fetch_map(remote_refs, tag_refspec, &tail, 0);
350
} else if (refmap_array) {
351
die("--refmap option is only meaningful with command-line refspec(s).");
352
} else {