@matheusbsbs / matheus-bagliano / commits / 6cfcabfb9f

pack-objects: allow `--filter` without `--stdout`

9535ce7337 (pack-objects: add list-objects filtering, 2017-11-21) taught `git pack-objects` to use `--filter`, but required the use of `--stdout` since a partial clone mechanism was not yet in place to handle missing objects. Since then, changes like 9e27beaa23 (promisor-remote: implement promisor_remote_get_direct(), 2019-06-25) and others added support to dynamically fetch objects that were missing. Even without a promisor remote, filtering out objects can also be useful if we can put the filtered out objects in a separate pack, and in this case it also makes sense for pack-objects to write the packfile directly to an actual file rather than on stdout. Remove the `--stdout` requirement when using `--filter`, so that in a follow-up commit, repack can pass `--filter` to pack-objects to omit certain objects from the resulting packfile. Signed-off-by: John Cai <johncai86@gmail.com> Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Christian Couder committed Oct 2, 2023 at 18:54 UTC 6cfcabfb9f60369f6fb4d24465a7c98b1d90b34b

3 files changed +12 -8

Documentation/git-pack-objects.txt

+2 -2

@@ -296,8 +296,8 @@ So does `git bundle` (see linkgit:git-bundle[1]) when it creates a bundle.

296 nevertheless.

297

298 --filter=<filter-spec>::

299 - Requires `--stdout`. Omits certain objects (usually blobs) from

300 - the resulting packfile. See linkgit:git-rev-list[1] for valid

299 + Omits certain objects (usually blobs) from the resulting

300 + packfile. See linkgit:git-rev-list[1] for valid

301 `<filter-spec>` forms.

302

303 --no-filter::

builtin/pack-objects.c

+2 -6

@@ -4402,12 +4402,8 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)

4402 if (!rev_list_all || !rev_list_reflog || !rev_list_index)

4403 unpack_unreachable_expiration = 0;

4404

4405 - if (filter_options.choice) {

4406 - if (!pack_to_stdout)

4407 - die(_("cannot use --filter without --stdout"));

4408 - if (stdin_packs)

4409 - die(_("cannot use --filter with --stdin-packs"));

4410 - }

4405 + if (stdin_packs && filter_options.choice)

4406 + die(_("cannot use --filter with --stdin-packs"));

4407

4408 if (stdin_packs && use_internal_rev_list)

4409 die(_("cannot use internal rev list with --stdin-packs"));

t/t5317-pack-objects-filter-objects.sh

@@ -53,6 +53,14 @@ test_expect_success 'verify blob:none packfile has no blobs' '

53 ! grep blob verify_result

54 '

56 +test_expect_success 'verify blob:none packfile without --stdout' '

57 + git -C r1 pack-objects --revs --filter=blob:none mypackname >packhash <<-EOF &&

58 + HEAD

59 + EOF

60 + git -C r1 verify-pack -v "mypackname-$(cat packhash).pack" >verify_result &&

61 + ! grep blob verify_result

62 +'

63 +

64 test_expect_success 'verify normal and blob:none packfiles have same commits/trees' '

65 git -C r1 verify-pack -v ../all.pack >verify_result &&

66 grep -E "commit|tree" verify_result |