@matheusbsbs / matheus-bagliano / commits / 6e4f981ffb
Fork 0

git-add: no need for -f when resolving a conflict in already tracked path

When a path F that matches ignore pattern has a conflict, "git add F" insisted the -f option be given, which did not make sense. It would have required -f when the path was originally added, but when resolving a conflict, it already is tracked. So this should work (and does): $ echo file >.gitignore $ echo content >file $ git add -f file ;# need -f because we are adding new path $ echo more content >>file $ git add file ;# don't need -f; it is not actually an "other" file This is handled under the hood by the COLLECT_IGNORED option to read_directory. When that code finds an ignored file, it checks the index to make sure it is not actually a tracked file. However, the test it uses does not take into account unmerged entries, and considers them to still be ignored. "git ls-files" uses a more elaborate test and gets the right answer and the same test should be used here. Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed May 30, 2009 at 17:54 UTC 6e4f981ffb88c8a9d3d6128314f4dd4f54ffb8a8
2 files changed +13 -1
dir.c
+1 -1
@@ -396,7 +396,7 @@ static struct dir_entry *dir_add_name(struct dir_struct *dir, const char *pathna
396
397 static struct dir_entry *dir_add_ignored(struct dir_struct *dir, const char *pathname, int len)
398 {
399 - if (cache_name_pos(pathname, len) >= 0)
399 + if (!cache_name_is_other(pathname, len))
400 return NULL;
401
402 ALLOC_GROW(dir->ignored, dir->ignored_nr+1, dir->ignored_alloc);
t/t3700-add.sh
+12
@@ -230,4 +230,16 @@ test_expect_success BSLASHPSPEC "git add 'fo\\[ou\\]bar' ignores foobar" '
230 ! ( git ls-files foobar | grep foobar )
231 '
232
233 +test_expect_success 'git add to resolve conflicts on otherwise ignored path' '
234 + git reset --hard &&
235 + H=$(git rev-parse :1/2/a) &&
236 + (
237 + echo "100644 $H 1 track-this"
238 + echo "100644 $H 3 track-this"
239 + ) | git update-index --index-info &&
240 + echo track-this >>.gitignore &&
241 + echo resolved >track-this &&
242 + git add track-this
243 +'
244 +
245 test_done