@matheusbsbs / matheus-bagliano / commits / 6e7e87c762
Fork 0

gitk: Fix bug in accessing undefined "notflag" variable

As pointed out by Johannes Sixt and Alexander Gavrilov, commit 2958228430b63f2e38c55519d1f98d8d6d9e23f3 ("gitk: Fix switch statement in parseviewargs") exposed a latent bug in that $notflag was never initialized. Since it isn't used either, this removes it entirely. Signed-off-by: Paul Mackerras <paulus@samba.org>

Paul Mackerras committed Dec 2, 2008 at 09:17 UTC 6e7e87c762fb0d8aa21c96c1d2c4596e46f2ab7b
1 file changed +1 -5
gitk
+1 -5
@@ -199,11 +199,7 @@ proc parseviewargs {n arglist} {
199 set nextisval 1
200 lappend glflags $arg
201 }
202 - "--not" {
203 - set notflag [expr {!$notflag}]
204 - lappend revargs $arg
205 - }
206 - "--all" {
202 + "--not" - "--all" {
203 lappend revargs $arg
204 }
205 "--merge" {