@matheusbsbs / matheus-bagliano / commits / 6ebedabf2d
Fork 0

gitk: Fix bug introduced by previous commit

When I added the "--" case to the code scanning the arguments, I missed the fact that since the switch statement uses -regexp, the "--" case will match any argument containing "--", e.g. "--all". This fixes it by taking out the -regexp (since we don't actually need regular expression matching) and adjusting the match strings. A side effect of this is that previously any argument starting with "-d" would be taken to indicate date mode; now the argument has to be exactly "-d" if you want date mode. Signed-off-by: Paul Mackerras <paulus@samba.org>

Paul Mackerras committed Jul 13, 2007 at 13:45 UTC 6ebedabf2d0f77c2c765ecc5effee1a7e3ffdedb
1 file changed +3 -3
gitk
+3 -3
@@ -7478,9 +7478,9 @@ set revtreeargs {}
7478 set cmdline_files {}
7479 set i 0
7480 foreach arg $argv {
7481 - switch -regexp -- $arg {
7482 - "^$" { }
7483 - "^-d" { set datemode 1 }
7481 + switch -- $arg {
7482 + "" { }
7483 + "-d" { set datemode 1 }
7484 "--" {
7485 set cmdline_files [lrange $argv [expr {$i + 1}] end]
7486 break