deprecate core.statinfo at Git 2.0 boundary
c08e4d5b5cfa (Enable minimal stat checking, 2013-01-22) advertised the configuration variable core.checkstat in the documentation and its log message, but the code expected core.statinfo instead. For now, add core.checkstat, and warn people who have core.statinfo in their configuration file that we will remove it in Git 2.0. Noticed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
May 6, 2013 at 22:31 UTC
6f4dd60d0713980cf976f569eb83850f9a28fe3c
1 file changed
+14
-1
config.c
+14
-1
@@ -566,7 +566,20 @@ static int git_default_core_config(const char *var, const char *value)
566
trust_ctime = git_config_bool(var, value);
567
return 0;
568
}
569
- if (!strcmp(var, "core.statinfo")) {
569
+ if (!strcmp(var, "core.statinfo") ||
570
+ !strcmp(var, "core.checkstat")) {
571
+ /*
572
+ * NEEDSWORK: statinfo was a typo in v1.8.2 that has
573
+ * never been advertised. we will remove it at Git
574
+ * 2.0 boundary.
575
+ */
576
+ if (!strcmp(var, "core.statinfo")) {
577
+ static int warned;
578
+ if (!warned++) {
579
+ warning("'core.statinfo' will be removed in Git 2.0; "
580
+ "use 'core.checkstat' instead.");
581
+ }
582
+ }
583
if (!strcasecmp(value, "default"))
584
check_stat = 1;
585
else if (!strcasecmp(value, "minimal"))