shortlog: fix segfault on empty authorname
The old code looked backwards from the email address to parse the name, allowing an arbitrary number of spaces between the two. However, in the case of no name, we looked back too far to the 'author' (or 'Author:') header. The bug was triggered by commit febf7ea4bed from linux-2.6. Jeff King originally fixed it by looking back only one character; Johannes Schindelin pointed out that we could try harder while at it to cope with commits with broken headers. Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano committed
Dec 10, 2006 at 15:51 UTC
6f9872582246b9b8ee4bdc9f6a563b409aab1ecb
1 file changed
+2
-1
builtin-shortlog.c
+2
-1
@@ -188,7 +188,8 @@ static void read_from_stdin(struct path_list *list)
188
bob = buffer + strlen(buffer);
189
else {
190
offset = 8;
191
- if (isspace(bob[-1]))
191
+ while (buffer + offset < bob &&
192
+ isspace(bob[-1]))
193
bob--;
194
}
195