add: create ADD_EDIT.patch with mode 0666
We should be letting the user's umask take care of restricting permissions. Even though this is a temporary file and probably nobody would notice, this brings us in line with other temporary file creations in git (e.g., choosing "e"dit from git-add--interactive). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jul 10, 2012 at 02:37 UTC
6ff2b729debc07fce5c5c1226f9fee9ea59cd7ab
1 file changed
+1
-1
builtin/add.c
+1
-1
@@ -281,7 +281,7 @@ static int edit_patch(int argc, const char **argv, const char *prefix)
281
argc = setup_revisions(argc, argv, &rev, NULL);
282
rev.diffopt.output_format = DIFF_FORMAT_PATCH;
283
DIFF_OPT_SET(&rev.diffopt, IGNORE_DIRTY_SUBMODULES);
284
- out = open(file, O_CREAT | O_WRONLY, 0644);
284
+ out = open(file, O_CREAT | O_WRONLY, 0666);
285
if (out < 0)
286
die (_("Could not open '%s' for writing."), file);
287
rev.diffopt.file = xfdopen(out, "w");