read_revisions_from_stdin: make copies for handle_revision_arg
read_revisions_from_stdin() has passed pointers to its read buffer down to handle_revision_arg() since its inception way back in 42cabc3 (Teach rev-list an option to read revs from the standard input., 2006-09-05). Even back then, this was a bug: through add_pending_object, the argument was recorded in the object_array's 'name' field. Fix it by making a copy whenever read_revisions_from_stdin() passes an argument down the callchain. The other caller runs handle_revision_arg() on argv[], where it would be redundant to make a copy. Signed-off-by: Thomas Rast <trast@inf.ethz.ch> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Thomas Rast committed
Apr 16, 2013 at 11:57 UTC
70d26c6e76d91c04ec53001a21f405b9883e3e3f
1 file changed
+2
-1
revision.c
+2
-1
@@ -1275,7 +1275,8 @@ static void read_revisions_from_stdin(struct rev_info *revs,
1275
}
1276
die("options not supported in --stdin mode");
1277
}
1278
- if (handle_revision_arg(sb.buf, revs, 0, REVARG_CANNOT_BE_FILENAME))
1278
+ if (handle_revision_arg(xstrdup(sb.buf), revs, 0,
1279
+ REVARG_CANNOT_BE_FILENAME))
1280
die("bad revision '%s'", sb.buf);
1281
}
1282
if (seen_dashdash)