t1050-large.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Apr 28, 2014 at 05:57 UTC
714c71b2b1531f7e1099d17ab8ae03fa21f4b88c
1 file changed
+2
-2
t/t1050-large.sh
+2
-2
@@ -131,7 +131,7 @@ test_expect_success 'git-show a large file' '
131
'
132
133
test_expect_success 'index-pack' '
134
- git clone file://"`pwd`"/.git foo &&
134
+ git clone file://"$(pwd)"/.git foo &&
135
GIT_DIR=non-existent git index-pack --strict --verify foo/.git/objects/pack/*.pack
136
'
137
@@ -140,7 +140,7 @@ test_expect_success 'repack' '
140
'
141
142
test_expect_success 'pack-objects with large loose object' '
143
- SHA1=`git hash-object huge` &&
143
+ SHA1=$(git hash-object huge) &&
144
test_create_repo loose &&
145
echo $SHA1 | git pack-objects --stdout |
146
GIT_ALLOC_LIMIT=0 GIT_DIR=loose/.git git unpack-objects &&