push: return immediately in trivial switch case
There's no need to break when nothing else will be executed. Will help next patches. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Felipe Contreras committed
May 31, 2021 at 14:51 UTC
72739680fc912c6e8dedaf06af4969f8e52ffb4d
1 file changed
+5
-5
builtin/push.c
+5
-5
index e3e792c69c..0aa1d0f07d 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -257,25 +257,25 @@ static void setup_default_push_refspecs(struct remote *remote)
default:
case PUSH_DEFAULT_MATCHING:
refspec_append(&rs, ":");
- break;
+ return;
case PUSH_DEFAULT_UNSPECIFIED:
case PUSH_DEFAULT_SIMPLE:
setup_push_simple(remote, branch, same_remote);
- break;
+ return;
case PUSH_DEFAULT_UPSTREAM:
setup_push_upstream(remote, branch, same_remote);
- break;
+ return;
case PUSH_DEFAULT_CURRENT:
setup_push_current(remote, branch);
- break;
+ return;
case PUSH_DEFAULT_NOTHING:
die(_("You didn't specify any refspecs to push, and "
"push.default is \"nothing\"."));
- break;
+ return;
}
}