push: return immediately in trivial switch case
There's no need to break when nothing else will be executed. Will help next patches. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Felipe Contreras committed
May 31, 2021 at 14:51 UTC
72739680fc912c6e8dedaf06af4969f8e52ffb4d
1 file changed
+5
-5
builtin/push.c
+5
-5
@@ -257,25 +257,25 @@ static void setup_default_push_refspecs(struct remote *remote)
257
default:
258
case PUSH_DEFAULT_MATCHING:
259
refspec_append(&rs, ":");
260
- break;
260
+ return;
261
262
case PUSH_DEFAULT_UNSPECIFIED:
263
case PUSH_DEFAULT_SIMPLE:
264
setup_push_simple(remote, branch, same_remote);
265
- break;
265
+ return;
266
267
case PUSH_DEFAULT_UPSTREAM:
268
setup_push_upstream(remote, branch, same_remote);
269
- break;
269
+ return;
270
271
case PUSH_DEFAULT_CURRENT:
272
setup_push_current(remote, branch);
273
- break;
273
+ return;
274
275
case PUSH_DEFAULT_NOTHING:
276
die(_("You didn't specify any refspecs to push, and "
277
"push.default is \"nothing\"."));
278
- break;
278
+ return;
279
}
280
}
281