t7401: use 'short' instead of 'verify' and cut in rev-parse calls
'git rev-parse' can limit the number of characters in the hash it outputs using the '--short' option, thereby, making the 'cut' invocation redundant. Since using '--short' implies '--verify' as well, we can safely replace the latter with the former. This change results in the helper functions getting the hash in the same way 'summary' gets the hash internally. So, avoid the unnecessary invocation to 'cut' in the helper functions. Mentored-by: Christian Couder <chriscool@tuxfamily.org> Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Shourya Shukla committed
Aug 21, 2020 at 22:29 UTC
7303da30021761b3a7c862d795e67ab74b5d66eb
1 file changed
+2
-2
t/t7401-submodule-summary.sh
+2
-2
@@ -21,7 +21,7 @@ add_file () {
21
test_tick &&
22
git commit -m "Add $name"
23
done >/dev/null
24
- git rev-parse --verify HEAD | cut -c1-7
24
+ git rev-parse --short HEAD
25
cd "$owd"
26
}
27
commit_file () {
@@ -125,7 +125,7 @@ commit_file sm1 &&
125
head3=$(
126
cd sm1 &&
127
git reset --hard HEAD~2 >/dev/null &&
128
- git rev-parse --verify HEAD | cut -c1-7
128
+ git rev-parse --short HEAD
129
)
130
131
test_expect_success 'modified submodule(backward)' "