@matheusbsbs / matheus-bagliano / commits / 738a8beac4

t0000: drop "known breakage" test

Having a simulated "known breakage" test means that the test suite will always tell us there is a bug to be fixed, even though it is only simulated. The right way to test this is in a sub-test, that can also check that we provide the correct exit status and output. Fortunately, we already have such a test (added much later by 5ebf89e). We could arguably get rid of the simulated success test immediately above, as well, as it is also redundant with the tests added in 5ebf89e. However, it does not have the annoying behavior of the "known breakage" test. It may also be easier to debug if the test suite is truly broken, since it is not a test-within-a-test, as the later tests are. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Dec 28, 2013 at 04:33 UTC 738a8beac42d5e2c6b882f997b7fc6577363c544

1 file changed -3

t/t0000-basic.sh

-3

@@ -41,9 +41,6 @@ test_expect_success '.git/objects should have 3 subdirectories' '

41 test_expect_success 'success is reported like this' '

42 :

43 '

44 -test_expect_failure 'pretend we have a known breakage' '

45 - false

46 -'

45 run_sub_test_lib_test () {

46 name="$1" descr="$2" # stdin is the body of the test code