t0300: use more realistic inputs
Many of the tests in t0300 give partial inputs to git-credential, omitting a protocol or hostname. We're checking only high-level things like whether and how helpers are invoked at all, and we don't care about specific hosts. However, in preparation for tightening up the rules about when we're willing to run a helper, let's start using input that's a bit more realistic: pretend as if http://example.com is being examined. This shouldn't change the point of any of the tests, but do note we have to adjust the expected output to accommodate this (filling a credential will repeat back the protocol/host fields to stdout, and the helper debug messages and askpass prompt will change on stderr). Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Jeff King committed
Apr 18, 2020 at 20:47 UTC
73aafe9bc27585554181c58871a25e6d0f58a3dc
1 file changed
+85
-4
t/t0300-credentials.sh
+85
-4
@@ -40,43 +40,71 @@ test_expect_success 'setup helper scripts' '
40
41
test_expect_success 'credential_fill invokes helper' '
42
check fill "verbatim foo bar" <<-\EOF
43
+ protocol=http
44
+ host=example.com
45
--
46
+ protocol=http
47
+ host=example.com
48
username=foo
49
password=bar
50
--
51
verbatim: get
52
+ verbatim: protocol=http
53
+ verbatim: host=example.com
54
EOF
55
'
56
57
test_expect_success 'credential_fill invokes multiple helpers' '
58
check fill useless "verbatim foo bar" <<-\EOF
59
+ protocol=http
60
+ host=example.com
61
--
62
+ protocol=http
63
+ host=example.com
64
username=foo
65
password=bar
66
--
67
useless: get
68
+ useless: protocol=http
69
+ useless: host=example.com
70
verbatim: get
71
+ verbatim: protocol=http
72
+ verbatim: host=example.com
73
EOF
74
'
75
76
test_expect_success 'credential_fill stops when we get a full response' '
77
check fill "verbatim one two" "verbatim three four" <<-\EOF
78
+ protocol=http
79
+ host=example.com
80
--
81
+ protocol=http
82
+ host=example.com
83
username=one
84
password=two
85
--
86
verbatim: get
87
+ verbatim: protocol=http
88
+ verbatim: host=example.com
89
EOF
90
'
91
92
test_expect_success 'credential_fill continues through partial response' '
93
check fill "verbatim one \"\"" "verbatim two three" <<-\EOF
94
+ protocol=http
95
+ host=example.com
96
--
97
+ protocol=http
98
+ host=example.com
99
username=two
100
password=three
101
--
102
verbatim: get
103
+ verbatim: protocol=http
104
+ verbatim: host=example.com
105
verbatim: get
106
+ verbatim: protocol=http
107
+ verbatim: host=example.com
108
verbatim: username=one
109
EOF
110
'
@@ -102,14 +130,20 @@ test_expect_success 'credential_fill passes along metadata' '
130
131
test_expect_success 'credential_approve calls all helpers' '
132
check approve useless "verbatim one two" <<-\EOF
133
+ protocol=http
134
+ host=example.com
135
username=foo
136
password=bar
137
--
138
--
139
useless: store
140
+ useless: protocol=http
141
+ useless: host=example.com
142
useless: username=foo
143
useless: password=bar
144
verbatim: store
145
+ verbatim: protocol=http
146
+ verbatim: host=example.com
147
verbatim: username=foo
148
verbatim: password=bar
149
EOF
@@ -117,6 +151,8 @@ test_expect_success 'credential_approve calls all helpers' '
151
152
test_expect_success 'do not bother storing password-less credential' '
153
check approve useless <<-\EOF
154
+ protocol=http
155
+ host=example.com
156
username=foo
157
--
158
--
@@ -126,14 +162,20 @@ test_expect_success 'do not bother storing password-less credential' '
162
163
test_expect_success 'credential_reject calls all helpers' '
164
check reject useless "verbatim one two" <<-\EOF
165
+ protocol=http
166
+ host=example.com
167
username=foo
168
password=bar
169
--
170
--
171
useless: erase
172
+ useless: protocol=http
173
+ useless: host=example.com
174
useless: username=foo
175
useless: password=bar
176
verbatim: erase
177
+ verbatim: protocol=http
178
+ verbatim: host=example.com
179
verbatim: username=foo
180
verbatim: password=bar
181
EOF
@@ -141,33 +183,49 @@ test_expect_success 'credential_reject calls all helpers' '
183
184
test_expect_success 'usernames can be preserved' '
185
check fill "verbatim \"\" three" <<-\EOF
186
+ protocol=http
187
+ host=example.com
188
username=one
189
--
190
+ protocol=http
191
+ host=example.com
192
username=one
193
password=three
194
--
195
verbatim: get
196
+ verbatim: protocol=http
197
+ verbatim: host=example.com
198
verbatim: username=one
199
EOF
200
'
201
202
test_expect_success 'usernames can be overridden' '
203
check fill "verbatim two three" <<-\EOF
204
+ protocol=http
205
+ host=example.com
206
username=one
207
--
208
+ protocol=http
209
+ host=example.com
210
username=two
211
password=three
212
--
213
verbatim: get
214
+ verbatim: protocol=http
215
+ verbatim: host=example.com
216
verbatim: username=one
217
EOF
218
'
219
220
test_expect_success 'do not bother completing already-full credential' '
221
check fill "verbatim three four" <<-\EOF
222
+ protocol=http
223
+ host=example.com
224
username=one
225
password=two
226
--
227
+ protocol=http
228
+ host=example.com
229
username=one
230
password=two
231
--
@@ -179,23 +237,31 @@ test_expect_success 'do not bother completing already-full credential' '
237
# askpass helper is run, we know the internal getpass is working.
238
test_expect_success 'empty helper list falls back to internal getpass' '
239
check fill <<-\EOF
240
+ protocol=http
241
+ host=example.com
242
--
243
+ protocol=http
244
+ host=example.com
245
username=askpass-username
246
password=askpass-password
247
--
186
- askpass: Username:
187
- askpass: Password:
248
+ askpass: Username for '\''http://example.com'\'':
249
+ askpass: Password for '\''http://askpass-username@example.com'\'':
250
EOF
251
'
252
253
test_expect_success 'internal getpass does not ask for known username' '
254
check fill <<-\EOF
255
+ protocol=http
256
+ host=example.com
257
username=foo
258
--
259
+ protocol=http
260
+ host=example.com
261
username=foo
262
password=askpass-password
263
--
198
- askpass: Password:
264
+ askpass: Password for '\''http://foo@example.com'\'':
265
EOF
266
'
267
@@ -207,7 +273,11 @@ HELPER="!f() {
273
test_expect_success 'respect configured credentials' '
274
test_config credential.helper "$HELPER" &&
275
check fill <<-\EOF
276
+ protocol=http
277
+ host=example.com
278
--
279
+ protocol=http
280
+ host=example.com
281
username=foo
282
password=bar
283
--
@@ -298,11 +368,16 @@ test_expect_success 'helpers can abort the process' '
368
test_must_fail git \
369
-c credential.helper=quit \
370
-c credential.helper="verbatim foo bar" \
301
- credential fill >stdout 2>stderr &&
371
+ credential fill >stdout 2>stderr <<-\EOF &&
372
+ protocol=http
373
+ host=example.com
374
+ EOF
375
>expect &&
376
test_cmp expect stdout &&
377
cat >expect <<-\EOF &&
378
quit: get
379
+ quit: protocol=http
380
+ quit: host=example.com
381
fatal: credential helper '\''quit'\'' told us to quit
382
EOF
383
test_i18ncmp expect stderr
@@ -311,11 +386,17 @@ test_expect_success 'helpers can abort the process' '
386
test_expect_success 'empty helper spec resets helper list' '
387
test_config credential.helper "verbatim file file" &&
388
check fill "" "verbatim cmdline cmdline" <<-\EOF
389
+ protocol=http
390
+ host=example.com
391
--
392
+ protocol=http
393
+ host=example.com
394
username=cmdline
395
password=cmdline
396
--
397
verbatim: get
398
+ verbatim: protocol=http
399
+ verbatim: host=example.com
400
EOF
401
'
402