serve: mark unused parameters in virtual functions

Each v2 "serve" action has a virtual function for advertising and implementing the command. A few of these are so trivial that they don't need to look at their parameters, especially the "repository" parameter. We can mark them so that -Wunused-parameter doesn't complain. Note that upload_pack_v2() probably _should_ be using its repository pointer. But teaching the functions it calls to do so is non-trivial. Even using it for something as simple as reading config is tricky, both because it shares code with the v1 upload pack, and because the git_protected_config() mechanism it uses does not have a repo-specific interface. So we'll just annotate it for now, and cleaning it up can be part of the larger work to drop references to the_repository. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Feb 24, 2023 at 01:38 UTC 74595cca21a41e4be6ca8d578d805b70b7653e98
2 files changed +6 -6
serve.c
+5 -5
@@ -12,13 +12,13 @@
12 static int advertise_sid = -1;
13 static int client_hash_algo = GIT_HASH_SHA1;
14
15 -static int always_advertise(struct repository *r,
16 - struct strbuf *value)
15 +static int always_advertise(struct repository *r UNUSED,
16 + struct strbuf *value UNUSED)
17 {
18 return 1;
19 }
20
21 -static int agent_advertise(struct repository *r,
21 +static int agent_advertise(struct repository *r UNUSED,
22 struct strbuf *value)
23 {
24 if (value)
@@ -34,7 +34,7 @@ static int object_format_advertise(struct repository *r,
34 return 1;
35 }
36
37 -static void object_format_receive(struct repository *r,
37 +static void object_format_receive(struct repository *r UNUSED,
38 const char *algo_name)
39 {
40 if (!algo_name)
@@ -57,7 +57,7 @@ static int session_id_advertise(struct repository *r, struct strbuf *value)
57 return 1;
58 }
59
60 -static void session_id_receive(struct repository *r,
60 +static void session_id_receive(struct repository *r UNUSED,
61 const char *client_sid)
62 {
63 if (!client_sid)
upload-pack.c
+1 -1
@@ -1699,7 +1699,7 @@ enum fetch_state {
1699 FETCH_DONE,
1700 };
1701
1702 -int upload_pack_v2(struct repository *r, struct packet_reader *request)
1702 +int upload_pack_v2(struct repository *r UNUSED, struct packet_reader *request)
1703 {
1704 enum fetch_state state = FETCH_PROCESS_ARGS;
1705 struct upload_pack_data data;