gitweb: Make running t9501 test with '--debug' reliable and usable

Remove test_debug lines after 'snapshots: tgz only default format enabled' and 'snapshots: all enabled in default, use default disabled value' tests. Those tests constitute of multiple gitweb_run invocation, therefore outputting gitweb.output for the last gitweb_run wouldn't help much in debugging test failure, and can only confuse. For snapshot tests which check for "200 OK" status, change test_debug 'cat gitweb.output' to test_debug 'cat gitweb.headers' Otherwise when running this test with '--debug' option, t/t9501-gitweb-standalone-http-status.sh would dump *binary data* (the snapshot itself) to standard output, which can mess up state of terminal due to term control characters which can be embedded in output. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jakub Narebski committed Jan 30, 2010 at 23:30 UTC 745a2db409c3b8346f28f6b2f1961b19051430f5

1 file changed +3 -5

t/t9501-gitweb-standalone-http-status.sh

+3 -5

@@ -33,7 +33,6 @@ test_expect_success \

33 grep "403 - Snapshot format not allowed" gitweb.output &&

34 gitweb_run "p=.git;a=snapshot;h=HEAD;sf=zip" &&

35 grep "403 - Unsupported snapshot format" gitweb.output'

36 -test_debug 'cat gitweb.output'

38 cat >>gitweb_config.perl <<\EOF

@@ -50,7 +49,6 @@ test_expect_success \

49 grep "403 - Snapshot format not allowed" gitweb.output &&

50 gitweb_run "p=.git;a=snapshot;h=HEAD;sf=zip" &&

51 grep "Status: 200 OK" gitweb.output'

53 -test_debug 'cat gitweb.output'

54 cat >>gitweb_config.perl <<\EOF

@@ -72,7 +70,7 @@ test_expect_success \

70 'snapshots: tgz explicitly enabled' \

71 'gitweb_run "p=.git;a=snapshot;h=HEAD;sf=tgz" &&

72 grep "Status: 200 OK" gitweb.output'

75 -test_debug 'cat gitweb.output'

73 +test_debug 'cat gitweb.headers'

76 # ----------------------------------------------------------------------

@@ -82,7 +80,7 @@ test_expect_success 'snapshots: good tree-ish id' '

80 gitweb_run "p=.git;a=snapshot;h=master;sf=tgz" &&

81 grep "Status: 200 OK" gitweb.output

82 '

85 -test_debug 'cat gitweb.output'

83 +test_debug 'cat gitweb.headers'

85 test_expect_success 'snapshots: bad tree-ish id' '

86 gitweb_run "p=.git;a=snapshot;h=frizzumFrazzum;sf=tgz" &&

@@ -105,7 +103,7 @@ test_expect_success 'snapshots: good object id' '

103 gitweb_run "p=.git;a=snapshot;h=$ID;sf=tgz" &&

104 grep "Status: 200 OK" gitweb.output

105 '

108 -test_debug 'cat gitweb.output'

106 +test_debug 'cat gitweb.headers'

107

108 test_expect_success 'snapshots: bad object id' '

109 gitweb_run "p=.git;a=snapshot;h=abcdef01234;sf=tgz" &&