refs/ref-cache.[ch]: remove "incomplete" from create_dir_entry()
Remove the now-unused "incomplete" parameter from create_dir_entry(), all its callers specify it as "1", so let's drop the "incomplete=0" case. The last caller to use it was search_for_subdir(), but that code was removed in the preceding commit. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Sep 28, 2021 at 15:02 UTC
750036c8f71368125b70f907fd369d5316571d01
3 files changed
+7
-9
refs/files-backend.c
+3
-3
@@ -227,7 +227,7 @@ static void add_per_worktree_entries_to_dir(struct ref_dir *dir, const char *dir
227
pos = search_ref_dir(dir, prefix, prefix_len);
228
if (pos >= 0)
229
continue;
230
- child_entry = create_dir_entry(dir->cache, prefix, prefix_len, 1);
230
+ child_entry = create_dir_entry(dir->cache, prefix, prefix_len);
231
add_entry_to_dir(dir, child_entry);
232
}
233
}
@@ -278,7 +278,7 @@ static void loose_fill_ref_dir(struct ref_store *ref_store,
278
strbuf_addch(&refname, '/');
279
add_entry_to_dir(dir,
280
create_dir_entry(dir->cache, refname.buf,
281
- refname.len, 1));
281
+ refname.len));
282
} else {
283
if (!refs_resolve_ref_unsafe(&refs->base,
284
refname.buf,
@@ -336,7 +336,7 @@ static struct ref_cache *get_loose_ref_cache(struct files_ref_store *refs)
336
* lazily):
337
*/
338
add_entry_to_dir(get_ref_dir(refs->loose->root),
339
- create_dir_entry(refs->loose, "refs/", 5, 1));
339
+ create_dir_entry(refs->loose, "refs/", 5));
340
}
341
return refs->loose;
342
}
refs/ref-cache.c
+3
-4
@@ -49,7 +49,7 @@ struct ref_cache *create_ref_cache(struct ref_store *refs,
49
50
ret->ref_store = refs;
51
ret->fill_ref_dir = fill_ref_dir;
52
- ret->root = create_dir_entry(ret, "", 0, 1);
52
+ ret->root = create_dir_entry(ret, "", 0);
53
return ret;
54
}
55
@@ -86,14 +86,13 @@ static void clear_ref_dir(struct ref_dir *dir)
86
}
87
88
struct ref_entry *create_dir_entry(struct ref_cache *cache,
89
- const char *dirname, size_t len,
90
- int incomplete)
89
+ const char *dirname, size_t len)
90
{
91
struct ref_entry *direntry;
92
93
FLEX_ALLOC_MEM(direntry, name, dirname, len);
94
direntry->u.subdir.cache = cache;
96
- direntry->flag = REF_DIR | (incomplete ? REF_INCOMPLETE : 0);
95
+ direntry->flag = REF_DIR | REF_INCOMPLETE;
96
return direntry;
97
}
98
refs/ref-cache.h
+1
-2
@@ -169,8 +169,7 @@ struct ref_dir *get_ref_dir(struct ref_entry *entry);
169
* "refs/heads/") or "" for the top-level directory.
170
*/
171
struct ref_entry *create_dir_entry(struct ref_cache *cache,
172
- const char *dirname, size_t len,
173
- int incomplete);
172
+ const char *dirname, size_t len);
173
174
struct ref_entry *create_ref_entry(const char *refname,
175
const struct object_id *oid, int flag);