t4014: treat rev-list output as the expected value
In 6bd26f58ea (t4014: use test_line_count() where possible, 2019-08-27), we converted many test cases to take advantage of the test_line_count() function. In one conversion, we inverted the expected and actual value as tested by test_line_count(). Although functionally correct, if format-patch ever produced incorrect output, the debugging output would be a bunch of hashes which would be difficult to debug. Invert the expected and actual values provided to test_line_count() so that if format-patch produces incorrect output, the debugging output will be a list of human-readable files instead. Helped-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Denton Liu committed
Oct 8, 2019 at 02:14 UTC
756fb0dedb72e8eec691d216198ccc23102d7072
1 file changed
+3
-2
t/t4014-format-patch.sh
+3
-2
@@ -1610,8 +1610,9 @@ test_expect_success 'format-patch format.outputDirectory option' '
1610
test_config format.outputDirectory patches &&
1611
rm -fr patches &&
1612
git format-patch master..side &&
1613
- git rev-list master..side >list &&
1614
- test_line_count = $(ls patches | wc -l) list
1613
+ count=$(git rev-list --count master..side) &&
1614
+ ls patches >list &&
1615
+ test_line_count = $count list
1616
'
1617
1618
test_expect_success 'format-patch -o overrides format.outputDirectory' '