t/{t5541,lib-httpd}: replace problematic '!()' notation with test_must_fail
The '!()' notation is interpreted as a pattern-list on Ksh. The Ksh man page describe it as follows: !(pattern-list) Matches anything except one of the given patterns. Ksh performs a file glob using the pattern-list and then tries to execute the first file in the list. If a space is added between the '!' and the open parens, then Ksh will not interpret it as a pattern list, but in this case, it is preferred to use test_must_fail, so lets do so. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brandon Casey committed
Jul 20, 2010 at 13:27 UTC
77b5be2abab69a69618dd40a6ca8b754388b8216
2 files changed
+2
-2
t/lib-httpd.sh
+1
-1
@@ -145,7 +145,7 @@ test_http_push_nonff() {
145
echo "changed" > path2 &&
146
git commit -a -m path2 --amend &&
147
148
- !(git push -v origin >output 2>&1) &&
148
+ test_must_fail git push -v origin >output 2>&1 &&
149
(cd "$REMOTE_REPO" &&
150
test $HEAD = $(git rev-parse --verify HEAD))
151
'
t/t5541-http-push.sh
+1
-1
@@ -128,7 +128,7 @@ test_expect_success 'push fails for non-fast-forward refs unmatched by remote he
128
129
# push master too; this ensures there is at least one '"'push'"' command to
130
# the remote helper and triggers interaction with the helper.
131
- !(git push -v origin +master master:retsam >output 2>&1) &&
131
+ test_must_fail git push -v origin +master master:retsam >output 2>&1 &&
132
133
grep "^ + [a-f0-9]*\.\.\.[a-f0-9]* *master -> master (forced update)$" output &&
134
grep "^ ! \[rejected\] *master -> retsam (non-fast-forward)$" output &&