diff: drop options parameter from diffcore_fix_diff_index()
The sole purpose of this function is to fix the sorting order of the queued diff entries. It doesn't need to know about any diff options, so we can drop the unused parameter. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Feb 14, 2019 at 00:48 UTC
784c0daed5435a7ea0630e64e424837e49e30148
3 files changed
+3
-3
diff-lib.c
+1
-1
@@ -531,7 +531,7 @@ int run_diff_index(struct rev_info *revs, int cached)
531
exit(128);
532
533
diff_set_mnemonic_prefix(&revs->diffopt, "c/", cached ? "i/" : "w/");
534
- diffcore_fix_diff_index(&revs->diffopt);
534
+ diffcore_fix_diff_index();
535
diffcore_std(&revs->diffopt);
536
diff_flush(&revs->diffopt);
537
trace_performance_leave("diff-index");
diff.c
+1
-1
@@ -6224,7 +6224,7 @@ static int diffnamecmp(const void *a_, const void *b_)
6224
return strcmp(name_a, name_b);
6225
}
6226
6227
-void diffcore_fix_diff_index(struct diff_options *options)
6227
+void diffcore_fix_diff_index(void)
6228
{
6229
struct diff_queue_struct *q = &diff_queued_diff;
6230
QSORT(q->queue, q->nr, diffnamecmp);
diff.h
+1
-1
@@ -367,7 +367,7 @@ int git_config_rename(const char *var, const char *value);
367
#define DIFF_PICKAXE_IGNORE_CASE 32
368
369
void diffcore_std(struct diff_options *);
370
-void diffcore_fix_diff_index(struct diff_options *);
370
+void diffcore_fix_diff_index(void);
371
372
#define COMMON_DIFF_OPTIONS_HELP \
373
"\ncommon diff options:\n" \