log: drop unused rev_info from early output
The early output code passes around a rev_info struct but doesn't need it. The setup step only turns on global signal handlers, and the "estimate" step is done completely from the rev->commits list that is passed in separately. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Mar 20, 2019 at 04:13 UTC
7954d365c64fd5cb854cf477aab3c12b8ff43f42
1 file changed
+5
-5
builtin/log.c
+5
-5
@@ -251,7 +251,7 @@ static void cmd_log_init(int argc, const char **argv, const char *prefix,
251
* This gives a rough estimate for how many commits we
252
* will print out in the list.
253
*/
254
-static int estimate_commit_count(struct rev_info *rev, struct commit_list *list)
254
+static int estimate_commit_count(struct commit_list *list)
255
{
256
int n = 0;
257
@@ -289,7 +289,7 @@ static void log_show_early(struct rev_info *revs, struct commit_list *list)
289
switch (simplify_commit(revs, commit)) {
290
case commit_show:
291
if (show_header) {
292
- int n = estimate_commit_count(revs, list);
292
+ int n = estimate_commit_count(list);
293
show_early_header(revs, "incomplete", n);
294
show_header = 0;
295
}
@@ -333,7 +333,7 @@ static void early_output(int signal)
333
show_early_output = log_show_early;
334
}
335
336
-static void setup_early_output(struct rev_info *rev)
336
+static void setup_early_output(void)
337
{
338
struct sigaction sa;
339
@@ -364,7 +364,7 @@ static void setup_early_output(struct rev_info *rev)
364
365
static void finish_early_output(struct rev_info *rev)
366
{
367
- int n = estimate_commit_count(rev, rev->commits);
367
+ int n = estimate_commit_count(rev->commits);
368
signal(SIGALRM, SIG_IGN);
369
show_early_header(rev, "done", n);
370
}
@@ -376,7 +376,7 @@ static int cmd_log_walk(struct rev_info *rev)
376
int saved_dcctc = 0, close_file = rev->diffopt.close_file;
377
378
if (rev->early_output)
379
- setup_early_output(rev);
379
+ setup_early_output();
380
381
if (prepare_revision_walk(rev))
382
die(_("revision walk setup failed"));