@matheusbsbs / matheus-bagliano / commits / 7a09a8f093

completion: add tests for 'git config' completion

The next patches will change/refactor the way we complete configuration variable names and values, so add a few tests to cover the basics, namely the completion of matching configuration sections, full variable names, and their values. Note that the test checking the completion of configuration sections is currently failing, though it's not a sign of an actual bug. If a section contains multiple variables, then that section is currently repeated as many times as the number of variables in there. This is not a correctness issue in practice, because Bash's completion facilities remove all repetitions anyway. Consequently, we could list all those repeated sections in the expected output of this test as well, but then it would have to be updated whenever a new configuration variable is added to those sections. Instead, list each matching configuration section only once, mark the test as failing for now, and the next patch will update the completion script to avoid those repetitions. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

SZEDER Gábor committed Aug 13, 2019 at 14:26 UTC 7a09a8f093eef940eef7d012907c051974ada254
1 file changed +21
t/t9902-completion.sh
+21
@@ -1698,6 +1698,27 @@ do
1698 '
1699 done
1700
1701 +test_expect_failure 'git config - section' '
1702 + test_completion "git config br" <<-\EOF
1703 + branch.Z
1704 + browser.Z
1705 + EOF
1706 +'
1707 +
1708 +test_expect_success 'git config - variable name' '
1709 + test_completion "git config log.d" <<-\EOF
1710 + log.date Z
1711 + log.decorate Z
1712 + EOF
1713 +'
1714 +
1715 +test_expect_success 'git config - value' '
1716 + test_completion "git config color.pager " <<-\EOF
1717 + false Z
1718 + true Z
1719 + EOF
1720 +'
1721 +
1722 test_expect_success 'sourcing the completion script clears cached commands' '
1723 __git_compute_all_commands &&
1724 verbose test -n "$__git_all_commands" &&