@matheusbsbs / matheus-bagliano / commits / 7a49c254cd
Fork 0

gitweb: git_get_project_config requires only $git_dir, not also $project

Fix overeager early return in git_get_project_config, introduced in 9be3614 (gitweb: Fix project-specific feature override behavior, 2010-03-01). When git_get_project_config is called from projects list page via git_get_project_owner($path) etc., it is called with $git_dir defined (in git_get_project_owner($path) etc.), but $project variable is not defined. git_get_project_config doesn't use $project variable anyway. Reported-by: Tobias Heinlein <keytoaster@gentoo.org> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jakub Narebski committed Mar 27, 2010 at 20:26 UTC 7a49c254cdaec6b15a6e2818e29fdb34fc6f7717
1 file changed +1 -2
gitweb/gitweb.perl
+1 -2
@@ -2209,8 +2209,7 @@ sub config_to_multi {
2209 sub git_get_project_config {
2210 my ($key, $type) = @_;
2211
2212 - # do we have project
2213 - return unless (defined $project && defined $git_dir);
2212 + return unless defined $git_dir;
2213
2214 # key sanity check
2215 return unless ($key);