ci(github): restore "print test failures" step name

As well as removing the explicit shell setting d8b21a0fe2 (CI: don't explicitly pick "bash" shell outside of Windows, fix regression, 2022-12-07) also reverted the name of the print test failures step introduced by 5aeb145780f (ci(github): bring back the 'print test failures' step, 2022-06-08). This is unfortunate as 5aeb145780f added a message to direct contributors to the "print test failures" step when a test fails and that step is no-longer known by that name on the non-windows ci jobs. In principle we could update the message to print the correct name for the step but then we'd have to deal with having two different names for the same step on different jobs. It is simpler for the implementation and contributors to use the same name for this step on all jobs. Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Phillip Wood committed Jan 3, 2023 at 10:27 UTC 7b341645e30bb94f186d31f27a62eb14107ae834
1 file changed +4 -2
.github/workflows/main.yml
+4 -2
@@ -261,8 +261,9 @@ jobs:
261 - uses: actions/checkout@v2
262 - run: ci/install-dependencies.sh
263 - run: ci/run-build-and-tests.sh
264 - - run: ci/print-test-failures.sh
264 + - name: print test failures
265 if: failure() && env.FAILED_TEST_ARTIFACTS != ''
266 + run: ci/print-test-failures.sh
267 - name: Upload failed tests' directories
268 if: failure() && env.FAILED_TEST_ARTIFACTS != ''
269 uses: actions/upload-artifact@v2
@@ -292,8 +293,9 @@ jobs:
293 - uses: actions/checkout@v1
294 - run: ci/install-docker-dependencies.sh
295 - run: ci/run-build-and-tests.sh
295 - - run: ci/print-test-failures.sh
296 + - name: print test failures
297 if: failure() && env.FAILED_TEST_ARTIFACTS != ''
298 + run: ci/print-test-failures.sh
299 - name: Upload failed tests' directories
300 if: failure() && env.FAILED_TEST_ARTIFACTS != ''
301 uses: actions/upload-artifact@v1