@matheusbsbs / matheus-bagliano / commits / 7ba826290a

revision: add rev_input_given flag

Normally a caller that invokes setup_revisions() has to check rev.pending to see if anything was actually queued for the traversal. But they can't tell the difference between two cases: 1. The user gave us no tip from which to start a traversal. 2. The user tried to give us tips via --glob, --all, etc, but their patterns ended up being empty. Let's set a flag in the rev_info struct that callers can use to tell the difference. We can set this from the init_all_refs_cb() function. That's a little funny because it's not exactly about initializing the "cb" struct itself. But that function is the common setup place for doing pattern traversals that is used by --glob, --all, etc. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Aug 2, 2017 at 18:25 UTC 7ba826290aa448bb9d0d45c3bb4b34905b741013

2 files changed +8

revision.c

@@ -1168,6 +1168,7 @@ static void init_all_refs_cb(struct all_refs_cb *cb, struct rev_info *revs,

1168 {

1169 cb->all_revs = revs;

1170 cb->all_flags = flags;

1171 + revs->rev_input_given = 1;

1172 }

1173

1174 void clear_ref_exclusion(struct string_list **ref_excludes_p)

revision.h

@@ -71,6 +71,13 @@ struct rev_info {

71 const char *def;

72 struct pathspec prune_data;

74 + /*

75 + * Whether the arguments parsed by setup_revisions() included any

76 + * "input" revisions that might still have yielded an empty pending

77 + * list (e.g., patterns like "--all" or "--glob").

78 + */

79 + int rev_input_given;

80 +

81 /* topo-sort */

82 enum rev_sort_order sort_order;