t1400: avoid SIGPIPE race condition on fifo

t1400.190 sometimes fails or even hangs because of the way it uses fifos. Our goal is to interactively read and write lines from update-ref, so we have two fifos, in and out. We open a descriptor connected to "in" and redirect output to that, so that update-ref does not see EOF as it would if we opened and closed it for each "echo" call. But we don't do the same for the output. This leads to a race where our "read response <out" has not yet opened the fifo, but update-ref tries to write to it and gets SIGPIPE. This can result in the test failing, or worse, hanging as we wait forever for somebody to write to the pipe. This is the same proble we fixed in 4783e7ea83 (t0008: avoid SIGPIPE race condition on fifo, 2013-07-12), and we can fix it the same way, by opening a second long-running descriptor. Before this patch, running: ./t1400-update-ref.sh --run=1,190 --stress failed or hung within a few dozen iterations. After it, I ran it for several hundred without problems. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Sep 15, 2021 at 13:24 UTC 7c1200745bec3034c98d6e44bd5f620849dbe2ba
1 file changed +5 -3
t/t1400-update-ref.sh
+5 -3
@@ -1603,11 +1603,13 @@ test_expect_success PIPE 'transaction flushes status updates' '
1603 (git update-ref --stdin <in >out &) &&
1604
1605 exec 9>in &&
1606 + exec 8<out &&
1607 test_when_finished "exec 9>&-" &&
1608 + test_when_finished "exec 8<&-" &&
1609
1610 echo "start" >&9 &&
1611 echo "start: ok" >expected &&
1610 - read line <out &&
1612 + read line <&8 &&
1613 echo "$line" >actual &&
1614 test_cmp expected actual &&
1615
@@ -1615,7 +1617,7 @@ test_expect_success PIPE 'transaction flushes status updates' '
1617
1618 echo prepare >&9 &&
1619 echo "prepare: ok" >expected &&
1618 - read line <out &&
1620 + read line <&8 &&
1621 echo "$line" >actual &&
1622 test_cmp expected actual &&
1623
@@ -1625,7 +1627,7 @@ test_expect_success PIPE 'transaction flushes status updates' '
1627
1628 echo commit >&9 &&
1629 echo "commit: ok" >expected &&
1628 - read line <out &&
1630 + read line <&8 &&
1631 echo "$line" >actual &&
1632 test_cmp expected actual
1633 '