@matheusbsbs / matheus-bagliano / commits / 7cd8f1cc6e

ci: add Ubuntu 16.04 job to GitLab CI

In the preceding commits we had to convert the linux32 job to be based on Ubuntu 20.04 instead of Ubuntu 16.04 due to a limitation in GitHub Workflows. This was the only job left that still tested against this old but supported Ubuntu version, and we have no other jobs that test with a comparatively old Linux distribution. Add a new job to GitLab CI that tests with Ubuntu 16.04 to cover the resulting test gap. GitLab doesn't modify Docker images in the same way GitHub does and thus doesn't fall prey to the same issue. There are two compatibility issues uncovered by this: - Ubuntu 16.04 does not support HTTP/2 in Apache. We thus cannot set `GIT_TEST_HTTPD=true`, which would otherwise cause us to fail when Apache fails to start. - Ubuntu 16.04 cannot use recent JGit versions as they depend on a more recent Java runtime than we have available. We thus disable installing any kind of optional dependencies that do not come from the package manager. These two restrictions are fine though, as we only really care about whether Git compiles and runs on such old distributions in the first place. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Patrick Steinhardt committed Sep 13, 2024 at 07:52 UTC 7cd8f1cc6e17af54fb78768c259a615b1ccc0205

3 files changed +16 -1

.gitlab-ci.yml

@@ -25,6 +25,9 @@ test:linux:

25 fi

26 parallel:

27 matrix:

28 + - jobname: linux-old

29 + image: ubuntu:16.04

30 + CC: gcc

31 - jobname: linux-sha256

32 image: ubuntu:latest

33 CC: clang

ci/install-dependencies.sh

@@ -55,6 +55,11 @@ ubuntu-*|ubuntu32-*)

55 ${CC_PACKAGE:-${CC:-gcc}} $PYTHON_PACKAGE

57 case "$distro" in

58 + ubuntu-16.04)

59 + # Does not support JGit, but we also don't really care about

60 + # the others. We rather care whether Git still compiles and

61 + # runs fine overall.

62 + ;;

63 ubuntu-*)

64 mkdir --parents "$CUSTOM_PATH"

ci/lib.sh

+8 -1

@@ -336,7 +336,14 @@ ubuntu-*)

336 fi

337 MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=/usr/bin/$PYTHON_PACKAGE"

338

339 - export GIT_TEST_HTTPD=true

339 + case "$distro" in

340 + ubuntu-16.04)

341 + # Apache is too old for HTTP/2.

342 + ;;

343 + *)

344 + export GIT_TEST_HTTPD=true

345 + ;;

346 + esac

347

348 # The Linux build installs the defined dependency versions below.

349 # The OS X build installs much more recent versions, whichever