gpg: close stderr once finished with it in verify_signed_buffer()
Failing to close the stderr pipe in verify_signed_buffer() causes git to run out of file descriptors if there are many calls to verify_signed_buffer(). An easy way to trigger this is to run git log --show-signature --merges | grep "key" on the linux kernel git repo. Eventually it will fail with error: cannot create pipe for gpg: Too many open files error: could not run gpg. Close the stderr pipe so that this can't happen. Suggested-by: Jeff King <peff@peff.net> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Stephen Boyd committed
Jan 31, 2013 at 10:18 UTC
7dac3f83218b9f6c4c7d1c1cf093190f20d27108
1 file changed
+3
-1
gpg-interface.c
+3
-1
@@ -128,8 +128,10 @@ int verify_signed_buffer(const char *payload, size_t payload_size,
128
write_in_full(gpg.in, payload, payload_size);
129
close(gpg.in);
130
131
- if (gpg_output)
131
+ if (gpg_output) {
132
strbuf_read(gpg_output, gpg.err, 0);
133
+ close(gpg.err);
134
+ }
135
ret = finish_command(&gpg);
136
137
unlink_or_warn(path);