@matheusbsbs / matheus-bagliano / commits / 7dbe8c8003

check-non-portable-shell.pl: `wc -l` may have leading WS

Test scripts count number of lines in an output and check it againt its expectation. fb3340a6 ("test-lib: introduce test_line_count to measure files", 2010-10-31) introduced a helper to show a failure in such a test in a more readable way than comparing `wc -l` output with a number. Besides, on some platforms, "$(wc -l <file)" is padded with leading whitespace on the left, so test "$(wc -l <file)" = 4 would not work (most notably on macosX); the users of test_line_count helper would not suffer from such a portability glitch. Add a check in check-non-portable-shell.pl to find '"' between `wc -l` and '=' and hint the user about test_line_count(). Signed-off-by: Torsten Bögershausen <tboegi@web.de> Reviewed-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Helped-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Torsten Bögershausen committed Dec 21, 2017 at 22:26 UTC 7dbe8c8003f3bec04f9dbbfff2b4bff172e52d9c

1 file changed +1

t/check-non-portable-shell.pl

@@ -21,6 +21,7 @@ while (<>) {

21 /^\s*declare\s+/ and err 'arrays/declare not portable';

22 /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';

23 /\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';

24 + /\bwc -l.*"\s*=/ and err '`"$(wc -l)"` is not portable (please use test_line_count)';

25 /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';

26 # this resets our $. for each file

27 close ARGV if eof;