t/Makefile: pass test opts to valgrind target properly
The valgrind target just reinvokes make with GIT_TEST_OPTS set to "--valgrind". However, it does this using an environment variable, which means GIT_TEST_OPTS in your config.mak would override it, and "make valgrind" would simply run the test suite without valgrind on. Instead, we should pass GIT_TEST_OPTS on the command-line, overriding what's in config.mak, and take care to append to whatever the user has there already. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jun 17, 2011 at 04:29 UTC
7ef4d6b928281eff2bfcd0b3d76b80f4385f2f3d
1 file changed
+1
-1
t/Makefile
+1
-1
@@ -71,7 +71,7 @@ gitweb-test:
71
$(MAKE) $(TGITWEB)
72
73
valgrind:
74
- GIT_TEST_OPTS=--valgrind $(MAKE)
74
+ $(MAKE) GIT_TEST_OPTS="$(GIT_TEST_OPTS) --valgrind"
75
76
# Smoke testing targets
77
-include ../GIT-VERSION-FILE