t0000: reword comments for "local" test
Commit 01d3a526ad (t0000: check whether the shell supports the "local" keyword, 2017-10-26) added a test to gather data on whether people run the test suite with shells that don't support "local". After almost two years, nobody has complained, and several other uses have cropped up in test-lib-functions.sh. Let's declare it acceptable to use. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Aug 8, 2019 at 05:37 UTC
7f0b5908759c59b77b39c62184166325e30f8878
1 file changed
+6
-8
t/t0000-basic.sh
+6
-8
@@ -25,16 +25,14 @@ try_local_x () {
25
echo "$x"
26
}
27
28
-# This test is an experiment to check whether any Git users are using
29
-# Shells that don't support the "local" keyword. "local" is not
28
+# Check whether the shell supports the "local" keyword. "local" is not
29
# POSIX-standard, but it is very widely supported by POSIX-compliant
31
-# shells, and if it doesn't cause problems for people, we would like
32
-# to be able to use it in Git code.
30
+# shells, and we rely on it within Git's test framework.
31
#
34
-# For now, this is the only test that requires "local". If your shell
35
-# fails this test, you can ignore the failure, but please report the
36
-# problem to the Git mailing list <git@vger.kernel.org>, as it might
37
-# convince us to continue avoiding the use of "local".
32
+# If your shell fails this test, the results of other tests may be
33
+# unreliable. You may wish to report the problem to the Git mailing
34
+# list <git@vger.kernel.org>, as it could cause us to reconsider
35
+# relying on "local".
36
test_expect_success 'verify that the running shell supports "local"' '
37
x="notlocal" &&
38
echo "local" >expected1 &&