@matheusbsbs / matheus-bagliano / commits / 7f9778b19b
Fork 0

gitweb: choose appropriate view for file type if a= parameter missing

gitweb URLs use the a= parameter for the view to use on the given path, such as "blob" or "tree". Currently, if a gitweb URL omits the a= parameter, gitweb just shows the top-level repository summary, regardless of the path given. gitweb could instead choose an appropriate view based on the file type: blob for blobs (files), tree for trees (directories), and summary if no path given (the URL included no f= parameter, or an empty f= parameter). Apart from making gitweb more robust and supporting URL editing more easily, this change would aid the creation of shortcuts to git repositories using simple substitution, such as: http://example.org/git/?p=path/to/repo.git;hb=HEAD;f=%s With this patch, if given the hash through the h= parameter, or the hash base (hb=) and a filename (f=), gitweb uses cat-file -t to automatically set the a= parameter. This feature was requested by Josh Triplett through http://bugs.debian.org/410465 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <junkio@cox.net>

Gerrit Pape committed May 10, 2007 at 07:32 UTC 7f9778b19b07601ae8134fc4ff23b7bf7cac28bd
1 file changed +10 -4
gitweb/gitweb.perl
+10 -4
@@ -458,10 +458,16 @@ my %actions = (
458 "project_index" => \&git_project_index,
459 );
460
461 -if (defined $project) {
462 - $action ||= 'summary';
463 -} else {
464 - $action ||= 'project_list';
461 +if (!defined $action) {
462 + if (defined $hash) {
463 + $action = git_get_type($hash);
464 + } elsif (defined $hash_base && defined $file_name) {
465 + $action = git_get_type("$hash_base:$file_name");
466 + } elsif (defined $project) {
467 + $action = 'summary';
468 + } else {
469 + $action = 'project_list';
470 + }
471 }
472 if (!defined($actions{$action})) {
473 die_error(undef, "Unknown action");