@matheusbsbs / matheus-bagliano / commits / 7fea9c5514
Fork 0

http-push: avoid a needless goto

There was a goto, and while it is not half as harmful as some people believe, it was unnecessary here. So remove it for readability. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Feb 14, 2008 at 23:26 UTC 7fea9c551436a98edf4ab6840de981f99b7db687
1 file changed +1 -4
http-push.c
+1 -4
@@ -2413,12 +2413,9 @@ int main(int argc, char **argv)
2413 } while (request_queue_head && !aborted);
2414
2415 /* Update the remote branch if all went well */
2416 - if (aborted || !update_remote(ref->new_sha1, ref_lock)) {
2416 + if (aborted || !update_remote(ref->new_sha1, ref_lock))
2417 rc = 1;
2418 - goto unlock;
2419 - }
2418
2421 - unlock:
2419 if (!rc)
2420 fprintf(stderr, " done\n");
2421 unlock_remote(ref_lock);