messages: mark some strings with "up-to-date" not to touch
The treewide clean-up of "up-to-date" strings done in 7560f547 (treewide: correct several "up-to-date" to "up to date", 2017-08-23) deliberately left some out, but unlike the lines that were changed by the commit, the lines that were deliberately left untouched by the commit is impossible to ask "git blame" to link back to the commit that did not touch them. Let's do the second best thing, leave a short comment near them explaining why those strings should not be modified or localized. Signed-off-by: Junio C Hamano <gitster@pobox.com> [es: make in-code comment more developer-friendly] Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Jan 12, 2024 at 12:19 UTC
80bdaba894b9868a74fa5931e3ce1ca074353b24
3 files changed
+4
builtin/send-pack.c
+1
@@ -338,6 +338,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)
338
}
339
340
if (!ret && !transport_refs_pushed(remote_refs))
341
+ /* stable plumbing output; do not modify or localize */
342
fprintf(stderr, "Everything up-to-date\n");
343
344
return ret;
http-push.c
+2
@@ -1845,6 +1845,7 @@ int cmd_main(int argc, const char **argv)
1845
1846
if (oideq(&ref->old_oid, &ref->peer_ref->new_oid)) {
1847
if (push_verbosely)
1848
+ /* stable plumbing output; do not modify or localize */
1849
fprintf(stderr, "'%s': up-to-date\n", ref->name);
1850
if (helper_status)
1851
printf("ok %s up to date\n", ref->name);
@@ -1865,6 +1866,7 @@ int cmd_main(int argc, const char **argv)
1866
* commits at the remote end and likely
1867
* we were not up to date to begin with.
1868
*/
1869
+ /* stable plumbing output; do not modify or localize */
1870
error("remote '%s' is not an ancestor of\n"
1871
"local '%s'.\n"
1872
"Maybe you are not up-to-date and "
transport.c
+1
@@ -1419,6 +1419,7 @@ int transport_push(struct repository *r,
1419
if (porcelain && !push_ret)
1420
puts("Done");
1421
else if (!quiet && !ret && !transport_refs_pushed(remote_refs))
1422
+ /* stable plumbing output; do not modify or localize */
1423
fprintf(stderr, "Everything up-to-date\n");
1424
1425
done: