ref-filter: rename 'FILTER_REFS_ALL' to 'FILTER_REFS_REGULAR'
The flag 'FILTER_REFS_ALL' is a bit ambiguous, where ALL doesn't specify if it means to contain refs from all worktrees or whether all types of refs (regular, HEAD & pseudorefs) or all of the above. Since here it is actually referring to all refs with the "refs/" prefix, let's rename it to 'FILTER_REFS_REGULAR' to indicate that this is specifically for regular refs. Signed-off-by: Karthik Nayak <karthik.188@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Karthik Nayak committed
Feb 23, 2024 at 11:01 UTC
810f7a1aace85ed9ffc454db6726c818c86685f0
3 files changed
+4
-4
builtin/for-each-ref.c
+1
-1
@@ -97,7 +97,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
97
}
98
99
filter.match_as_path = 1;
100
- filter_and_format_refs(&filter, FILTER_REFS_ALL, sorting, &format);
100
+ filter_and_format_refs(&filter, FILTER_REFS_REGULAR, sorting, &format);
101
102
ref_filter_clear(&filter);
103
ref_sorting_release(sorting);
ref-filter.c
+1
-1
@@ -3041,7 +3041,7 @@ static int do_filter_refs(struct ref_filter *filter, unsigned int type, each_ref
3041
ret = for_each_fullref_in("refs/remotes/", fn, cb_data);
3042
else if (filter->kind == FILTER_REFS_TAGS)
3043
ret = for_each_fullref_in("refs/tags/", fn, cb_data);
3044
- else if (filter->kind & FILTER_REFS_ALL)
3044
+ else if (filter->kind & FILTER_REFS_REGULAR)
3045
ret = for_each_fullref_in_pattern(filter, fn, cb_data);
3046
if (!ret && (filter->kind & FILTER_REFS_DETACHED_HEAD))
3047
head_ref(fn, cb_data);
ref-filter.h
+2
-2
@@ -19,10 +19,10 @@
19
#define FILTER_REFS_BRANCHES 0x0004
20
#define FILTER_REFS_REMOTES 0x0008
21
#define FILTER_REFS_OTHERS 0x0010
22
-#define FILTER_REFS_ALL (FILTER_REFS_TAGS | FILTER_REFS_BRANCHES | \
22
+#define FILTER_REFS_REGULAR (FILTER_REFS_TAGS | FILTER_REFS_BRANCHES | \
23
FILTER_REFS_REMOTES | FILTER_REFS_OTHERS)
24
#define FILTER_REFS_DETACHED_HEAD 0x0020
25
-#define FILTER_REFS_KIND_MASK (FILTER_REFS_ALL | FILTER_REFS_DETACHED_HEAD)
25
+#define FILTER_REFS_KIND_MASK (FILTER_REFS_REGULAR | FILTER_REFS_DETACHED_HEAD)
26
27
struct atom_value;
28
struct ref_sorting;