@matheusbsbs / matheus-bagliano / commits / 814291cf3f

t5510-fetch: fix negated 'test_i18ngrep' invocation

The test '--no-show-forced-updates' in 't5510-fetch.sh' added in cdbd70c437 (fetch: add --[no-]show-forced-updates argument, 2019-06-18) runs '! test_i18ngrep ...'. This is wrong, because when running the test with GIT_TEST_GETTEXT_POISON=true, then 'test_i18ngrep' is basically a noop and always returns with success, the leading ! turns that into a failure, which then fails the test. Use 'test_i18ngrep ! ...' instead. This went unnoticed by our GETTEXT_POISON CI builds, because those builds don't run this test case: in those builds we don't install Apache, and this test comes after 't5510' sources 'lib-httpd.sh', which, consequently, skips all the remaining tests, including this one. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

SZEDER Gábor committed Jul 30, 2019 at 23:29 UTC 814291cf3f286ddffc291e4820c62ac729e83171

1 file changed +1 -1

t/t5510-fetch.sh

+1 -1

@@ -997,7 +997,7 @@ test_expect_success '--no-show-forced-updates' '

997 (

998 cd no-forced-update-clone &&

999 git fetch --no-show-forced-updates origin 2>output &&

1000 - ! test_i18ngrep "(forced update)" output

1000 + test_i18ngrep ! "(forced update)" output

1001 )

1002 '

1003