git-remote-mediawiki: change syntax of map calls
Put first parameter of map inside a block, for better readability. Follow BuiltinFunctions::RequireBlockMap Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr> Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Célestin Matte committed
Jun 14, 2013 at 15:50 UTC
81f6a7a43d8c0b1310ffc2df6f9e8d607799249c
1 file changed
+8
-6
contrib/mw-to-git/git-remote-mediawiki.perl
+8
-6
@@ -371,7 +371,7 @@ sub get_all_mediafiles {
371
372
sub get_linked_mediafiles {
373
my $pages = shift;
374
- my @titles = map $_->{title}, values(%{$pages});
374
+ my @titles = map { $_->{title} } values(%{$pages});
375
376
# The query is split in small batches because of the MW API limit of
377
# the number of links to be returned (500 links max).
@@ -399,11 +399,13 @@ sub get_linked_mediafiles {
399
while (my ($id, $page) = each(%{$result->{query}->{pages}})) {
400
my @media_titles;
401
if (defined($page->{links})) {
402
- my @link_titles = map $_->{title}, @{$page->{links}};
402
+ my @link_titles
403
+ = map { $_->{title} } @{$page->{links}};
404
push(@media_titles, @link_titles);
405
}
406
if (defined($page->{images})) {
406
- my @image_titles = map $_->{title}, @{$page->{images}};
407
+ my @image_titles
408
+ = map { $_->{title} } @{$page->{images}};
409
push(@media_titles, @image_titles);
410
}
411
if (@media_titles) {
@@ -833,7 +835,7 @@ sub mw_import_ref_by_pages {
835
my ($n, @revisions) = fetch_mw_revisions(\@pages, $fetch_from);
836
837
@revisions = sort {$a->{revid} <=> $b->{revid}} @revisions;
836
- my @revision_ids = map $_->{revid}, @revisions;
838
+ my @revision_ids = map { $_->{revid} } @revisions;
839
840
return mw_import_revids($fetch_from, \@revision_ids, \%pages_hash);
841
}
@@ -1246,8 +1248,8 @@ sub get_allowed_file_extensions {
1248
siprop => 'fileextensions'
1249
};
1250
my $result = $mediawiki->api($query);
1249
- my @file_extensions= map $_->{ext},@{$result->{query}->{fileextensions}};
1250
- my %hashFile = map {$_ => 1}@file_extensions;
1251
+ my @file_extensions = map { $_->{ext}} @{$result->{query}->{fileextensions}};
1252
+ my %hashFile = map { $_ => 1 } @file_extensions;
1253
1254
return %hashFile;
1255
}