clone: call transport_set_verbosity before anything else on the newly created transport
Commit 2879bc3 made the progress and verbosity options sent to remote helper earlier than they previously were. But nothing else after that would send updates if the value is changed later on with transport_set_verbosity. While for fetch and push, transport_set_verbosity is the first thing that is done after creating the transport, it was not the case for clone. So commit 2879bc3 broke changing progress and verbosity for clone, for urls requiring a remote helper only (so, not git:// urls, for instance). Moving transport_set_verbosity to just after the transport is created works around the issue. Signed-off-by: Mike Hommey <mh@glandium.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Mike Hommey committed
May 12, 2015 at 13:30 UTC
822f0c4ff716ed356fb56cf39a5b0900313e40fb
1 file changed
+2
-2
builtin/clone.c
+2
-2
@@ -905,6 +905,8 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
905
906
remote = remote_get(option_origin);
907
transport = transport_get(remote, remote->url[0]);
908
+ transport_set_verbosity(transport, option_verbosity, option_progress);
909
+
910
path = get_repo_path(remote->url[0], &is_bundle);
911
is_local = option_local != 0 && path && !is_bundle;
912
if (is_local) {
@@ -931,8 +933,6 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
933
if (option_single_branch)
934
transport_set_option(transport, TRANS_OPT_FOLLOWTAGS, "1");
935
934
- transport_set_verbosity(transport, option_verbosity, option_progress);
935
-
936
if (option_upload_pack)
937
transport_set_option(transport, TRANS_OPT_UPLOADPACK,
938
option_upload_pack);