send-email: multiedit is a boolean config option
The sendemail.multiedit variable is meant to be a boolean. However, it is not marked as such in the code, which means we store its value literally. Thus in the do_edit function, perl ends up coercing it to a boolean value according to perl rules, not git rules. This works for "0", but "false", "no", or "off" will erroneously be interpreted as true. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jan 9, 2012 at 17:55 UTC
829a1c616967176ccd859c18a6e8ca0dda77f75a
1 file changed
+1
-1
git-send-email.perl
+1
-1
@@ -210,6 +210,7 @@ my %config_bool_settings = (
210
"signedoffbycc" => [\$signed_off_by_cc, undef],
211
"signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated
212
"validate" => [\$validate, 1],
213
+ "multiedit" => [\$multiedit, undef]
214
);
215
216
my %config_settings = (
@@ -227,7 +228,6 @@ my %config_settings = (
228
"bcc" => \@bcclist,
229
"suppresscc" => \@suppress_cc,
230
"envelopesender" => \$envelope_sender,
230
- "multiedit" => \$multiedit,
231
"confirm" => \$confirm,
232
"from" => \$sender,
233
"assume8bitencoding" => \$auto_8bit_encoding,