revision: disallow reflog walking with revs->limited

The reflog-walk code doesn't work with limit_list(). That function traverses down the real history graph, not the fake reflog history that get_revision() returns. So it's not going to actually examine all of the commits we're going to show, because we'd add them to the pending list only during the actual traversal. In practice this limitation doesn't really matter, because the options that require list-limiting generally need UNINTERESTING endpoints or symmetric ranges, which already are forbidden for reflog walks. Still, there are likely some corner cases that would behave oddly. We're better off to warn the user that we can't fulfill their request than to generate potentially wrong output. This will also make it easier to refactor the reflog-walking code, because it eliminates a whole area of corner cases we'd have to consider (that already don't work anyway). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Jul 7, 2017 at 05:07 UTC 82fd0f4a4b2c394ddba279eab7072fe87b750d2e
1 file changed +2
revision.c
+2
@@ -2366,6 +2366,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
2366
2367 if (revs->reverse && revs->reflog_info)
2368 die("cannot combine --reverse with --walk-reflogs");
2369 + if (revs->reflog_info && revs->limited)
2370 + die("cannot combine --walk-reflogs with history-limiting options");
2371 if (revs->rewrite_parents && revs->children.name)
2372 die("cannot combine --parents and --children");
2373