@matheusbsbs / matheus-bagliano / commits / 832ac79edf
Fork 0

t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression

Regular expressions matched by 'expr' have an implicit '^' at the beginning of them and so are anchored to the beginning of the string. Using the '^' character to mean "match at the beginning", is redundant and could produce the wrong result if 'expr' implementations interpret the '^' as a literal '^'. Additionally, GNU expr 5.97 complains like this: expr: warning: unportable BRE: `^[a-z][a-z]*$': using `^' as the first character of the basic regular expression is not portable; it is being ignored Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Brandon Casey committed Jun 21, 2010 at 12:37 UTC 832ac79edf0e0e9108f5da5b10b496a227667f40
1 file changed +1 -1
t/lib-pager.sh
+1 -1
@@ -9,7 +9,7 @@ test_expect_success 'determine default pager' '
9 test -n "$less"
10 '
11
12 -if expr "$less" : '^[a-z][a-z]*$' >/dev/null
12 +if expr "$less" : '[a-z][a-z]*$' >/dev/null
13 then
14 test_set_prereq SIMPLEPAGER
15 fi