sha1_name: don't resolve refs when core.warnambiguousrefs is false
When seeing a full 40-hex object name, get_sha1_basic() unconditionally checks if the string can also be interpreted as a refname, but the result will not be used unless warn_ambiguous_refs is in effect. Omitting this unnecessary ref resolution provides a substantial performance improvement, especially when passing many hashes to a command (like "git rev-list --stdin") and core.warnambiguousrefs is set to false. The check incurs 6 stat()s for every hash supplied, which can be costly over NFS. Signed-off-by: Brodie Rao <brodie@sf.io> Acked-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Acked-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brodie Rao committed
Jan 6, 2014 at 19:32 UTC
832cf74c0792a58c9c28e32a8fe5dbb694f0cce6
1 file changed
+2
-2
sha1_name.c
+2
-2
@@ -451,9 +451,9 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
451
int at, reflog_len, nth_prior = 0;
452
453
if (len == 40 && !get_sha1_hex(str, sha1)) {
454
- if (warn_on_object_refname_ambiguity) {
454
+ if (warn_ambiguous_refs && warn_on_object_refname_ambiguity) {
455
refs_found = dwim_ref(str, len, tmp_sha1, &real_ref);
456
- if (refs_found > 0 && warn_ambiguous_refs) {
456
+ if (refs_found > 0) {
457
warning(warn_msg, len, str);
458
if (advice_object_name_warning)
459
fprintf(stderr, "%s\n", _(object_name_msg));